Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: search by lowercase function name #16866

Closed
wants to merge 8 commits into from
Closed

fix: search by lowercase function name #16866

wants to merge 8 commits into from

Conversation

notauserx
Copy link
Contributor

@notauserx notauserx commented Nov 18, 2024 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://docs.databend.com/dev/policies/cla/

Summary

Update logic to search by the lowercase of func_name
fixes: #16737

Tests

  • Unit Test
  • Logic Test
  • Benchmark Test
  • No Test

Type of change

  • Bug Fix (non-breaking change which fixes an issue)
  • New Feature (non-breaking change which adds functionality)
  • Breaking Change (fix or feature that could cause existing functionality not to work as expected)
  • Documentation Update
  • Refactoring
  • Performance Improvement
  • Other (please describe):

This change is Reviewable

@notauserx notauserx changed the title search by lowercase function name fix(query): search by lowercase function name Nov 18, 2024
@github-actions github-actions bot added the pr-bugfix this PR patches a bug in codebase label Nov 18, 2024
@notauserx notauserx changed the title fix(query): search by lowercase function name fix: search by lowercase function name Nov 18, 2024
@BohuTANG BohuTANG requested a review from sundy-li November 18, 2024 23:05
@sundy-li
Copy link
Member

need add test to cover the issue

@notauserx notauserx closed this Nov 22, 2024
@notauserx notauserx deleted the search-by-lowercase-func-name branch November 22, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
pr-bugfix this PR patches a bug in codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@notauserx @sundy-li